events: Integer returns the documented range error instead of a wrong number - #640
Open
lenamonj wants to merge 1 commit into
Open
events: Integer returns the documented range error instead of a wrong number#640lenamonj wants to merge 1 commit into
lenamonj wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 36 36
Lines 1419 1425 +6
=======================================
+ Hits 1169 1174 +5
- Misses 247 248 +1
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamoDBAttributeValue.Integerdocuments that a value outside int64 comes back as the maximum magnitude int64 of the matching sign witherr.Err = ErrRange.strconv.ParseIntreturns exactly that, butIntegertreats every parse error as a decimal string and retries withParseFloat, which succeeds and drops the error: on amd64NewNumberAttribute("99999999999999999999").Integer()returns-9223372036854775808, nil, the wrong sign and no error. DynamoDB numbers carry up to 38 digits, so this is ordinary content.The change keeps the
ParseFloatfallback for syntax errors only and saturates withErrRangewhen a parsed float is outside int64 as well;"123.45"still returns 123. The new test fails on main and passes with the change.go test -race ./events/and golangci-lint v2.13.1 are clean.