fix(insight): build OpenSearchExporter without the auth artifact - #717
Merged
wangyb-A merged 1 commit intoSep 15, 2026
Merged
Conversation
- Hold the credentials provider as Object so building the exporter never links the auth types - Cast inside Signer, created on first SigV4 export - Cover OpenSearchExporter in OptionalArtifactTest with http-auth-aws and auth removed
2 tasks
wangyb-A
marked this pull request as ready for review
September 15, 2026 18:45
wangyb-A
had a problem deploying
to
ai-pr-review-runtime
September 15, 2026 19:01 — with
GitHub Actions
Error
wangyb-A
added this pull request to stack #718
September 15, 2026 19:09
Contributor
Codex AI reviewNo actionable findings. Residual risk: tests were not executed because the review was restricted to read-only inspection. Reviewed commit |
nvasiu
approved these changes
Sep 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Stacked on #704; addresses #704 (comment)
Description
OpenSearchExporter.build()threwNoClassDefFoundErrorwhensoftware.amazon.awssdk:authwas absent, in both auth modes: the constructor's lambda captured anAwsCredentialsProviderlocal, so linking the call site loaded the optional type. The provider is now held asObjectand cast insideSigner, which is created on first SigV4 export, so only that path links the auth artifact. The missing-artifact message now names bothhttp-auth-awsandauth.Demo/Screenshots
N/A
Checklist
Testing
Unit Tests
OptionalArtifactTestgains three cases: SigV4 withhttp-auth-awsremoved and withauthremoved (build succeeds, export fails naming the artifacts), and basic auth withauthremoved (build succeeds, export delivers). The isolated loader now parents to the platform loader sojava.net.httpresolves.mvn -pl insight-plugin clean install: 144 tests pass.Integration Tests
Not applicable.
Examples
Not applicable.