Conversation
targets.json lists tune/arch keys alongside real targets. NON_BOARD_RE
filtered them by pattern ("boards never use '_'"), so any future target
whose name matches would be silently dropped and the sweep matrix would
quietly shrink.
Replace it with IGNORE_TARGETS, an exact-match list of the platform/tune
keys actually published in 2024/edge. Anything new that is not a real
target now falls through to install and fails loudly rather than
disappearing from the plan. icam-540 is ignored as a top-level key only;
it is still built as a board of jetson-orin-nx via feed_boards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
feed_targetsfiltered non-target keys out oftargets.jsonwith a regex heuristic:NON_BOARD_RE='_|^noarch$|^qcm[0-9]+$'That rests on "boards never use
_". Replaced withIGNORE_TARGETS— an exact-match (grep -vxF) list of the platform/tune keys actually published in 2024/edge.Why
The heuristic fails silently in the direction that hurts: a future real target whose name contains an underscore gets dropped from the plan, the sweep runs a smaller matrix, and it still goes green. Same failure mode the
_fetchrc-1 contract already guards against ("unknown, abort — never treat as empty").With an explicit list, anything new that is not a real target falls through to
install, fails loudly with noavocado-sdk-<name>, and gets added to the list.Note on icam-540
icam-540wasn't caught by the old regex, so it was being swept as a top-level target. It's a board ofjetson-orin-nx— it's now ignored as a target key and still built as a board viafeed_boards. That's the one behavioral change to the matrix.Trade-off
The list needs a manual edit when the feed adds a tune. Deliberate: the failure mode is a loud red cell instead of a quietly partial sweep.