Skip to content

fix(samples): add missing onClick handler and remove invalid signInUrl in tanstack-router sample #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KavishkaVenuka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(samples): add missing onClick handler and remove invalid signInUrl in tanstack-router sample #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions samples/react-tanstack-router/src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ createRoot(document.getElementById('root')!).render(
<AsgardeoProvider
baseUrl={import.meta.env.VITE_ASGARDEO_BASE_URL}
clientId={import.meta.env.VITE_ASGARDEO_CLIENT_ID}
signInUrl="/signin"
signUpUrl="/signup"
scopes="openid profile email"
>
<RouterProvider router={router} />
Expand Down
12 changes: 10 additions & 2 deletions samples/react-tanstack-router/src/pages/Home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ export default function Home() {
</>
) : (
<SignInButton>
{({isLoading}) => <button disabled={isLoading}>{isLoading ? 'Loading...' : 'Sign In'}</button>}
{({isLoading, signIn}) => (
<button onClick={signIn} disabled={isLoading}>
{isLoading ? 'Loading...' : 'Sign In'}
</button>
)}
</SignInButton>
)}
</div>
Expand All @@ -34,7 +38,11 @@ export default function Home() {
{!isSignedIn && (
<div>
<SignInButton>
{({isLoading}) => <button disabled={isLoading}>{isLoading ? 'Loading...' : 'Get Started'}</button>}
{({isLoading, signIn}) => (
<button onClick={signIn} disabled={isLoading}>
{isLoading ? 'Loading...' : 'Get Started'}
</button>
)}
</SignInButton>
</div>
)}
Expand Down