[ZEPPELIN-6691] Terminate shell terminal process on WebSocket close - #5447
Open
seung-00 wants to merge 1 commit into
Open
[ZEPPELIN-6691] Terminate shell terminal process on WebSocket close#5447seung-00 wants to merge 1 commit into
seung-00 wants to merge 1 commit into
Conversation
seung-00
force-pushed
the
ZEPPELIN-6691
branch
from
August 31, 2026 06:41
50bcb1f to
41ab1bb
Compare
seung-00
force-pushed
the
ZEPPELIN-6691
branch
from
August 31, 2026 06:47
41ab1bb to
daf51ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR ensures that the
PtyProcesscreated for the interactive shell terminal in the Shell Interpreter is terminated when the terminal WebSocket is closed.Previously, the process was not closed when the terminal was closed. This could allow shell processes to accumulate in the background.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6691
How should this be tested?
Run a paragraph with
%sh.terminaland confirm that a shell terminal process is started.Move away from the notebook page or close the browser tab, then confirm that the same process exits.
Screenshots (if appropriate)
Questions: