Skip to content

Fix building on OpenBSD - #3737

Merged
Jens-G merged 1 commit into
apache:masterfrom
brad0:cpp_src_thrift_transport_openbsd
Aug 28, 2026
Merged

Fix building on OpenBSD#3737
Jens-G merged 1 commit into
apache:masterfrom
brad0:cpp_src_thrift_transport_openbsd

Conversation

@brad0

@brad0 brad0 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Replace the check for AI_ADDRCONFIG with AI_V4MAPPED. OpenBSD
has had AI_ADDRCONFIG for 12 years / 23 releases ago. Fill in missing
CMake bits.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@brad0
brad0 requested a review from Jens-G as a code owner August 23, 2026 03:24
@mergeable mergeable Bot added the build and general CI cmake, automake and build system changes label Aug 23, 2026
Replace the check for AI_ADDRCONFIG with AI_V4MAPPED. OpenBSD
has had AI_ADDRCONFIG for 12 years. Fill in missing CMake bits.
@brad0
brad0 force-pushed the cpp_src_thrift_transport_openbsd branch from fbeb7f6 to 7ff64a8 Compare August 23, 2026 03:51
@Jens-G

Jens-G commented Aug 27, 2026

Copy link
Copy Markdown
Member

But AI_V4MAPPED and AI_ADDRCONFIG are two different things?

@brad0

brad0 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

But AI_V4MAPPED and AI_ADDRCONFIG are two different things?

I am very much aware of that.

The comment in the code indicated this was added for OpenBSD. As I said up above we added AI_ADDRCONFIG 12 years ago / 23 releases ago. If you're building with CMake the bits for dealing with AI_ADDRCONFIG are missing anyway.

@Jens-G
Jens-G merged commit 405a95f into apache:master Aug 28, 2026
95 checks passed
@brad0
brad0 deleted the cpp_src_thrift_transport_openbsd branch August 28, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build and general CI cmake, automake and build system changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants