Skip to content

Use the supported SSLSession accessor for the peer certificate chain - #121

Merged
isudana merged 1 commit into
apache:masterfrom
ThisaraWeerakoon:fix/nhttp-revocation-peer-certificate-api
Nov 12, 2026
Merged

isudana merged 1 commit into
apache:masterfrom
ThisaraWeerakoon:fix/nhttp-revocation-peer-certificate-api

Conversation

@ThisaraWeerakoon

@ThisaraWeerakoon ThisaraWeerakoon commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Enabling the opt-in CertificateRevocationVerifier parameter breaks every outbound HTTPS connection on JDK 17, because the peer chain is read through SSLSession.getPeerCertificateChain(), whose default implementation throws UnsupportedOperationException — unchecked, so it escapes the catch (CertificateVerificationException) guarding the call.

Both senders now use SSLSession.getPeerCertificates(), with java.security.cert.Certificate[] carried through SynapseAdaptorForOcspCrl and RevocationVerificationManager; OCSPVerifier and CRLVerifier still receive the same X509Certificate[] as before.

@ThisaraWeerakoon
ThisaraWeerakoon force-pushed the fix/nhttp-revocation-peer-certificate-api branch from 428af5b to 668d894 Compare November 11, 2026 10:10
@isudana
isudana merged commit 7b6a1ab into apache:master Nov 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants