chore: Migrate off Decompose/MVIKotlin/Essenty stack - #4929
Draft
malliaridis wants to merge 9 commits into
Draft
malliaridis wants to merge 9 commits into
malliaridis wants to merge 9 commits into
Conversation
DefaultLoggingComponent had no state or behavior, so it no longer needs the component context or store factory. DefaultMainComponent creates it without a child context, like the configsets component. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The cluster tab selection moves from a Decompose child slot into a ClusterViewModel exposing a StateFlow, and ClusterComponent becomes a factory for it, as in configsets. ClusterContent uses the state-based NavigationTabs, so the Decompose overload and TabNavigationComponent are removed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The MVIKotlin store, provider and client are replaced with the pattern used by configsets: an EnvironmentRepository (HTTP), load use cases, an EnvironmentStateHolder wrapped by an EnvironmentViewModel, and EnvironmentComponent as a factory. EnvironmentContent gets a stateless overload that takes the UI state, which the UI test now uses. The store tests are rewritten against the state holder. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The start store is replaced with a StartRepository (HTTP), a ConnectUseCase that validates the URL and classifies the outcome, and a StartStateHolder wrapped by a StartViewModel. Store labels and the StartComponent.Output callback become a StartEvent flow that StartContent hands to its parent via onEvent, which the still Decompose-based root uses for navigation until it is migrated. StartContent gets a stateless overload used by the previews and the UI test; the integration test now exercises the state holder with the real use case and repository. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The three auth stores are replaced with the pattern used by configsets: BasicAuthRepository and OAuthRepository (from the store clients), use cases for basic authentication, OAuth authorization requests and OAuth authentication (which also normalize errors), and state holders for basic auth, OAuth and the shared authentication state. The AuthenticationViewModel wraps them, and AuthenticationComponent is now only a factory. The child slots and Output callbacks are gone: the authentication state holder builds the child state holders from the supported methods and collects their events into the shared state. BasicAuthComponent, OAuthComponent and their implementations are removed, as they only existed as Decompose children. The auth views are stateless and take state plus callbacks; UserAuthenticationContent hosts them via slots, hands AuthenticationEvents to its parent and opens the OAuth authorization URL. The store and component tests are rewritten against the state holders. Note: until the root is migrated, view models created by the Decompose based root live as long as the window and are not scoped to a child. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Decompose child stacks of the root and main components are replaced with Navigation 3 back stacks held by a RootViewModel and a MainViewModel, following the routing pattern of the configsets section. RootComponent and MainComponent are now factories for the components of their screens, the Start/Authentication/Main outputs became events handled by the RootViewModel, and MainMenu navigation keeps the bring-to-front semantics of the previous stack. Transitions are disabled to keep the previous behavior, and the back handlers never pop the last entry, as NavDisplay requires a non-empty back stack. Screens are now created per back stack entry and their view models are scoped to it, so they are cleared when the entry leaves the back stack. That also fixes the window-scoped view models noted in the previous commit. The desktop and web entry points no longer create a lifecycle, component context or store factory. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
With all components migrated, the remaining glue is removed: the AppComponentContext and its default implementation, the lifecycle-aware coroutine scope helpers and the test component context. The decompose, essenty and mvikotlin dependencies are dropped from the shared, desktopApp and webApp modules, together with their entries (including the unused mvikotlin-logging) in the version catalog. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The technology overview no longer describes Decompose, MVIKotlin and Essenty and introduces the AndroidX ViewModel and Navigation 3 libraries instead. The module structure, component development and testing pages describe the repository, use case, state holder and view model layers, the component as a factory, event-based communication with parents, back stack based navigation and how to test state holders. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Since the UI became an independent sub-project, the :solr:ui paths in the developer docs no longer resolve. The commands now use `-p ui` with the :desktopApp and :webApp projects, the web run task is the existing wasmJsBrowserDevelopmentRun instead of the non-existent wasmJsBrowserRun (also in the README), the README's desktop command gets its missing `ui` project directory, and the packaged output path and module name are corrected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the new UI module was introduced, we started with the default stack of Decompose, MVIKotlin and Essenty, mainly because other official libraries from JetBrains and Google were not multiplatform-ready or had limited support for web-targets.
Ever since, the
ViewModeland official navigation library received significant progress in multiplatform, allowing us to migrate and move away from the mentioned libraries above. This reduces the dependency footprint and third-party libraries and follows more "official" and well-supported patterns and libraries.Solution
Migrate all existing components to use
ViewModels,UseCases andNav3and remove related libraries of the previous MVI pattern.This migration was mainly guided by Claude Code.
Tests
Tests are updated to use the new patterns.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.