Skip to content

SOLR-18468: Rename --prompt-inputs to --session-inputs - #4927

Open
serhiy-bzhezytskyy wants to merge 1 commit into
apache:mainfrom
serhiy-bzhezytskyy:SOLR-18468-rename-session-inputs
Open

serhiy-bzhezytskyy wants to merge 1 commit into
apache:mainfrom
serhiy-bzhezytskyy:SOLR-18468-rename-session-inputs

Conversation

@serhiy-bzhezytskyy

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-18468

Description

--prompt-inputs is already documented in deployment-guide/solr-control-script-reference.adoc -- it was added in the same PR that introduced the feature (#4127, merged 2026-02-18), including a usage example and a note about quoting on Windows. Checked guide/solr/latest directly: it's Solr 10.0 and doesn't have it yet, so that's a publishing lag, not a documentation gap -- it'll show up once a release picks up main.

On the rename: the overload is real. bin/solr already has three differently-shaped --prompt* flags on one script:

  • --prompt <true|false> under auth enable -- a boolean, whether to prompt for credentials
  • --no-prompt under start -e -- skip the interactive session, use defaults
  • --prompt-inputs <values> under start -e -- skip the interactive session, use these values instead

Solution

Renamed --prompt-inputs to --session-inputs. Considered three options:

  • --example-inputs (your suggestion) -- rejected. -e/--example <name> already means "which built-in example to run" (cloud, techproducts, schemaless, films), so --example-inputs reads as input about the example, not answers to a prompt. Trades one overload for another.
  • --answers <values> -- workable, no collisions, but doesn't tie to any existing term in the guide.
  • --session-inputs <values> -- picked this one. The guide already calls this flow an "interactive session" in three places (this page and tutorial-solrcloud.adoc), and the code's own output says "This interactive session will help you launch a SolrCloud cluster." Reuses an existing term instead of adding a new one, and doesn't collide with -e, --prompt, or --no-prompt.

Didn't touch --no-prompt, even though it has the same --prompt* collision shape: it dates to 2014 (SOLR-3617), a decade in every release, versus --prompt-inputs's 7 months entirely unreleased. Renaming it would be a real breaking change for a widely-used flag, and that's a separate call from this ticket.

Clean rename, no deprecated alias -- --prompt-inputs has never shipped in a release, so there's no compatibility cost to weigh against the simplicity.

Full sweep, not just the flag name: RunExampleTool.java (option constant, the usingPromptInputs field, the CloudExampleParams record component, the mutual-exclusivity error message), bin/solr and bin/solr.cmd (help text and arg parsing), TestSolrCLIRunExample.java (test name, variables, assertion message), the ref guide, and the still-unreleased changelog entry for #4127 (its title said --prompt-inputs; corrected since it hasn't shipped under that name).

Tests

Ran the actual integration test, not just a recompile: ./gradlew :solr:core:test --tests TestSolrCLIRunExample -- 6/6 pass, including the renamed testSolrCloudExampleWithSessionInputs, which starts a real SolrCloud example via --session-inputs and checks the collection it creates. Also -Pvalidation.errorprone=true compile (clean; errorprone is skipped by default locally but -Werror in CI) and buildLocalAntoraSite + checkSiteLinks for the ref guide (clean, no broken links). Repo-wide grep for every old identifier -- zero hits outside gitignored build output.

AI-assisted (Claude Sonnet 5).

bin/solr already has --prompt under auth enable and --no-prompt under start -e; adding --prompt-inputs made three differently-shaped --prompt* flags on one script. The interactive setup flow is already called an 'interactive session' throughout the ref guide, so --session-inputs reuses that term instead of adding a new overload. The flag has been unreleased for its whole 7-month life (main only), so this is a clean rename with no deprecated alias.
@serhiy-bzhezytskyy

Copy link
Copy Markdown
Contributor Author

@epugh tagging you since this is under SOLR-18459/SOLR-18468, which you filed.

@github-actions github-actions Bot added documentation Improvements or additions to documentation start-scripts tests cat:cli labels Sep 20, 2026
@epugh

epugh commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

I've been struggling a lot on this one.... --session-inputs seems to generic... What about "--script-inputs"? I could potentially imagine that at some point in the future you could use something like that for multiple bin/solr tools, like the bin/solr package....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:cli documentation Improvements or additions to documentation start-scripts tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants