SOLR-18468: Rename --prompt-inputs to --session-inputs - #4927
Open
serhiy-bzhezytskyy wants to merge 1 commit into
Open
serhiy-bzhezytskyy wants to merge 1 commit into
serhiy-bzhezytskyy wants to merge 1 commit into
Conversation
bin/solr already has --prompt under auth enable and --no-prompt under start -e; adding --prompt-inputs made three differently-shaped --prompt* flags on one script. The interactive setup flow is already called an 'interactive session' throughout the ref guide, so --session-inputs reuses that term instead of adding a new overload. The flag has been unreleased for its whole 7-month life (main only), so this is a clean rename with no deprecated alias.
Contributor
Author
|
@epugh tagging you since this is under SOLR-18459/SOLR-18468, which you filed. |
Contributor
|
I've been struggling a lot on this one.... --session-inputs seems to generic... What about "--script-inputs"? I could potentially imagine that at some point in the future you could use something like that for multiple bin/solr tools, like the bin/solr package.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18468
Description
--prompt-inputsis already documented indeployment-guide/solr-control-script-reference.adoc-- it was added in the same PR that introduced the feature (#4127, merged 2026-02-18), including a usage example and a note about quoting on Windows. Checked guide/solr/latest directly: it's Solr 10.0 and doesn't have it yet, so that's a publishing lag, not a documentation gap -- it'll show up once a release picks up main.On the rename: the overload is real.
bin/solralready has three differently-shaped--prompt*flags on one script:--prompt <true|false>underauth enable-- a boolean, whether to prompt for credentials--no-promptunderstart -e-- skip the interactive session, use defaults--prompt-inputs <values>understart -e-- skip the interactive session, use these values insteadSolution
Renamed
--prompt-inputsto--session-inputs. Considered three options:--example-inputs(your suggestion) -- rejected.-e/--example <name>already means "which built-in example to run" (cloud, techproducts, schemaless, films), so--example-inputsreads as input about the example, not answers to a prompt. Trades one overload for another.--answers <values>-- workable, no collisions, but doesn't tie to any existing term in the guide.--session-inputs <values>-- picked this one. The guide already calls this flow an "interactive session" in three places (this page andtutorial-solrcloud.adoc), and the code's own output says "This interactive session will help you launch a SolrCloud cluster." Reuses an existing term instead of adding a new one, and doesn't collide with-e,--prompt, or--no-prompt.Didn't touch
--no-prompt, even though it has the same--prompt*collision shape: it dates to 2014 (SOLR-3617), a decade in every release, versus--prompt-inputs's 7 months entirely unreleased. Renaming it would be a real breaking change for a widely-used flag, and that's a separate call from this ticket.Clean rename, no deprecated alias --
--prompt-inputshas never shipped in a release, so there's no compatibility cost to weigh against the simplicity.Full sweep, not just the flag name:
RunExampleTool.java(option constant, theusingPromptInputsfield, theCloudExampleParamsrecord component, the mutual-exclusivity error message),bin/solrandbin/solr.cmd(help text and arg parsing),TestSolrCLIRunExample.java(test name, variables, assertion message), the ref guide, and the still-unreleased changelog entry for #4127 (its title said--prompt-inputs; corrected since it hasn't shipped under that name).Tests
Ran the actual integration test, not just a recompile:
./gradlew :solr:core:test --tests TestSolrCLIRunExample-- 6/6 pass, including the renamedtestSolrCloudExampleWithSessionInputs, which starts a real SolrCloud example via--session-inputsand checks the collection it creates. Also-Pvalidation.errorprone=truecompile (clean; errorprone is skipped by default locally but-Werrorin CI) andbuildLocalAntoraSite+checkSiteLinksfor the ref guide (clean, no broken links). Repo-wide grep for every old identifier -- zero hits outside gitignored build output.AI-assisted (Claude Sonnet 5).