Migrate Admin UI screens to v2 endpoints: Java Properties, Schema, and Cloud Zookeeper tree view - #4901
Open
epugh wants to merge 8 commits into
Open
Migrate Admin UI screens to v2 endpoints: Java Properties, Schema, and Cloud Zookeeper tree view#4901epugh wants to merge 8 commits into
epugh wants to merge 8 commits into
Conversation
…m updateschema UpdateSchema was not responding properly, it had errors but return ad 200, which wasn't how v2 is uspposed to work.
…ren stat map in listNodes response ZooKeeperListChildrenResponse's `unknownFields` was serialized twice: once as its own literal property (a public field Jackson auto-detects) and again flattened via @JsonAnyGetter. @JsonIgnore on the field removes the first copy
Documents the UpdateSchema fix (200-instead-of-4xx on failure) landed in c068793, under SOLR-18439. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The schema error-reporting fix's changelog entry duplicated SOLR-18439 coverage already provided by the separate replication/backup fix's changelog entry on another branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
epugh
marked this pull request as ready for review
September 15, 2026 17:28
Contributor
Author
|
This needs a bit of review... |
epugh
commented
Sep 16, 2026
|
|
||
| var cookie_schema_browser_autoload = 'schema-browser_autoload'; | ||
|
|
||
| // SchemaV2 (the generated OpenAPI client) uses superagent directly, so genuine transport/auth |
Contributor
Author
There was a problem hiding this comment.
too much? This is the one place we do kind of werid stuff with error handling.
epugh
changed the title
epugh
changed the title
epugh
changed the title
Contributor
Author
|
The Schema tool needs a bit of love: Not sure why the dropdown isn't loading, no errors int he browser... |
epugh
commented
Sep 16, 2026
| .factory('ZookeeperReadV2', | ||
| ['$http', function($http) { | ||
| // Hand-rolled rather than the generated solrApi.ZookeeperReadApi client: the generated | ||
| // ApiClient.buildUrl() runs encodeURIComponent() on the whole zkPath value, turning its '/' |
Contributor
Author
There was a problem hiding this comment.
I tried to deal with this, and we neded up hacking up OpenAPI annotation templates!
Contributor
Author
fixed! |
Contributor
Author
|
assuming a good build, will merge on Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate Solr Admin UI to V2 equivalent APIs that have already been merged in.
Solution
We have a number of V2 apis that haven't been used in the Solr Admin yet. We migrated the Java Properties, the Schema UI, and the Cloud panels "Zookeeper tree" to V2 equivalents.
Tests
manual and selenium.