do not close the stream inside CCITTFactory.extractFromTiff method - #501
Closed
valerybokov wants to merge 1 commit into
Closed
do not close the stream inside CCITTFactory.extractFromTiff method#501valerybokov wants to merge 1 commit into
valerybokov wants to merge 1 commit into
Conversation
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 28, 2026
#501 git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/3.0@1937553 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 28, 2026
#501 git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/2.0@1937554 13f79535-47bb-0310-9956-ffa450edef68
Contributor
|
Thank you. It turns out I introduced this in 2014 (before that the close was needed). I didn't use the PR, I remove the close manually, hopefully that is the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code doesn't throw an IOException or other error, but the code structure is incorrect. It is fragile. We write data to the output stream in the extractFromTiff method, close it, and then read the data from outside in the createFromRandomAccessImpl method. But the stream is closed. We can do it only because this is ByteArrayOutputStream. If we change the stream type then there will be an exception.