GH-3760: Clean up hadoop README.md - #3761
Merged
Merged
Conversation
Fokko
approved these changes
Sep 3, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ggershinsky for cleaning this up. This is the reason why I prefer to use soft-line wraps in the editor, instead of line-breaks :D
divjotarora
reviewed
Sep 3, 2026
Comment on lines
-293
to
-295
| **Property:** `parquet.crypto.factory.class` | ||
| **Description:** Class implementing EncryptionPropertiesFactory. | ||
| **Default value:** None. If not set, the file won't be encrypted by a crypto factory. |
Contributor
There was a problem hiding this comment.
Is this actually a duplicate? This parameter is under section Class: ParquetOutputFormat and references EncryptionPropertiesFactory. The duplicate below is under section Class: HadoopReadOptions and references DecryptionPropertiesFactory. I'm fine removing it if there's precedent to not duplicate, but it does seem to be used for two different things.
Contributor
Author
There was a problem hiding this comment.
Thanks. Yep, it makes sense to list the same parameter twice, in both output (encrypt) and read (decrypt) sections. I'll update the patch.
divjotarora
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
In the Hadoop README.md doc, fix format of a number of parameters (no line breaks, because spaces are missing)