[vortex] Honor write.batch-memory in the writer factory - #9605
Open
thswlsqls wants to merge 1 commit into
Open
Conversation
VortexFileFormat.createWriterFactory built ArrowFormatCWriter with the three-argument constructor, so the write.batch-memory limit was dropped and only write.batch-size bounded a batch. Pass the limit through, as orc, lance and mosaic already do. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #9559
VortexFileFormat.createWriterFactory()never passedwrite.batch-memorytoArrowFormatCWriter, so onlywrite.batch-sizebounded a batch. This passes it through.ArrowFormatCWriterreplacedArrowFormatWriter. If that was intentional, please close this — [Bug] Vortex writer ignores write.batch-memory #9559 asks the same.CoreOptions.Tests
VortexFileFormatTest#testWriterFactoryHonorsWriteBatchMemory: at a 1 kb limitwrite()is rejected beforewrite.batch-size; at 128 MB it is not.mvn -pl paimon-vortex/paimon-vortex-format clean install(JDK 11) — 66 tests, 0 failures, 4 skipped; checkstyle, spotless, enforcer green.write.batch-memory, so none change behavior.