[core] Fix stale option key in clustering.strategy description - #9602
Open
thswlsqls wants to merge 1 commit into
Open
[core] Fix stale option key in clustering.strategy description#9602thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
The description of 'clustering.strategy' referred to 'clustering.by-columns', which is not a valid option key. The primary key is 'clustering.columns' and its fallback key is 'sink.clustering.by-columns'. Update the description and the generated configuration table accordingly. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
clustering.strategysays the algorithm is chosen from the number of columns in'clustering.by-columns', but no such option key exists in Paimon.clustering.columns, withsink.clustering.by-columnskept only as its fallback. Users following the current text silently get no clustering.2558c585c(addedclustering.columns, madesink.clustering.by-columnsa fallback) and continued in4e7e4188e(dropped the deprecatedsink.prefix but kept the old suffix). It does not restore thesink.prefix.docs/generated/core_configuration.htmlrenders the same string, so both files are updated together, matching [core] Fix stale default value in sort-compaction.range-strategy description #9104.Tests
mvn -pl paimon-api clean installpassed (checkstyle, spotless, 184 unit tests).ConfigOptionsDocsCompletenessITCaseinpaimon-docspassed; reverting only the HTML makes it fail onclustering.strategy.