[arrow] Fix second-precision timestamp conversion for pre-epoch values - #9600
Open
thswlsqls wants to merge 1 commit into
Open
[arrow] Fix second-precision timestamp conversion for pre-epoch values#9600thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #9599
ArrowUtils.nonCastedTimestampToEpoch()computed the epoch second forprecision == 0astimestamp.getMillisecond() / 1000. Java integer division truncates towards zero, so a pre-epoch value with sub-second millis moves forward across the epoch boundary:-500(1969-12-31T23:59:59.500) becomes0, i.e.1970-01-01T00:00:00Z.Math.floorDivso truncation goes towards negative infinity. The 1-3, 4-6 and 7-9 precision branches are already negative-safe and are untouched.Arrow2PaimonVectorConverter.convertEpochToTimestamp).Tests
ArrowFormatWriterTest#testWritePreEpochSecondPrecisionTimestamp: anArrowFormatWriter->ArrowBatchReaderround trip overTIMESTAMP(0)andTIMESTAMP_LTZ(0). It fails on master (expected: "1969-12-31T23:59:59" but was: "1970-01-01T00:00") and passes with the fix.mvn -pl paimon-arrow clean install— 71 tests passed, 0 failures.