[common] Fail on a short remote read instead of caching zero padding - #9593
Merged
Conversation
The block returned by readRemote is cached, so tolerating a short read turned one truncated remote read into a durable zero-padded block. The VectoredReadable branch in the same method already throws via preadFully; use IOUtils.readFully for the other one.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CachingSeekableInputStream.readRemotefills a block with a privatereadFullythat breaks out of its loop on EOF and returns the partially filled buffer, zero-padded.readBlockhands that buffer tocache.putBlock, so one short remote read becomes a durable wrong answer — persisted to disk underLocalDiskCacheManager— for every later read of the block.The
VectoredReadablebranch two lines above already usespreadFully, which throws. UseIOUtils.readFully, already imported here, and drop the local copy.Tests
CachingFileIOTest#testShortRemoteReadIsNotCachedAsZeroPaddedBlock.Written with Claude Code; reasoning and verification are mine.