[common] Fix pre-epoch timestamp casts truncating toward zero - #9577
Merged
Conversation
Integer division rounds toward zero, so for the negative epoch millis of a pre-epoch timestamp both helpers moved the value forward in time instead of dropping the sub-precision digits. Floor instead, matching the sibling DATE and TIME cast rules.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
zeroLastDigitsandunixTimestampdrop the low digits with integer division, which rounds toward zero. Epoch millis are negative before 1970, so both move the value forward instead of flooring: narrowing1969-12-31 23:59:59.999999toTIMESTAMP(0)yields1970-01-01 00:00:00, and-1500millis casts to epoch second-1instead of-2.Reached from
TimestampToTimestampCastRuleandTimestampToNumericPrimitiveCastRule. Flooring is what #9203 and #8769 chose for the sibling DATE and TIME casts, and whatDateTimeUtils.flooralready does in the same file.Tests
DateTimeUtilsTest,CastExecutorTest.Written with Claude Code; reasoning and verification are mine.