[spark] Reject variant extraction paths containing the metadata delimiter - #9569
Merged
JingsongLi merged 1 commit intoSep 4, 2026
Merged
Conversation
…iter The extraction path is encoded into the field description and split back on ";" with no escaping, so a path carrying the delimiter decodes into a different path. Skip the pushdown for such paths and assert the invariant in the encoder, mirroring the MAP selected-keys guards.
jackylee-ch
force-pushed
the
variant-path-delimiter-guard
branch
from
September 4, 2026 04:55
3548c33 to
ecb29b0
Compare
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A variant extraction path is encoded into the projected field's description as
__VARIANT_METADATA<path>;<failOnError>;<timeZoneId>and split back on;with no escaping.VariantPathSegmentallows;in a key, so$.a;bdecodes as path$.awithfailOnError=falseandZoneId.of("true"), while$.a;true;UTCre-splits into a valid triple and reads a different field.Skip the pushdown for such paths, and assert the invariant in the encoder. The MAP selected-keys path already pairs the same two guards on this delimiter.
Tests
VariantMetadataUtilsTest,VariantPushDownUtilsTest.Written with Claude Code; reasoning and verification are mine.