Skip to content

Update to NB master and fix missing OSGI runtime - #35

Open
matthiasblaesing wants to merge 1 commit into
apache:masterfrom
matthiasblaesing:missing-osgi-runtime
Open

Update to NB master and fix missing OSGI runtime#35
matthiasblaesing wants to merge 1 commit into
apache:masterfrom
matthiasblaesing:missing-osgi-runtime

Conversation

@matthiasblaesing

Copy link
Copy Markdown
Contributor

With apache/netbeans@f067194 NetBinox was removed from NetBeans. For reasoning please refer to the corresponding commit.

For the IDE this not a problem as NetBeans was delivered with two OSGI runtimes (Netbinox and Apache Felix) and the second runtime took over. VSCode was broken as Apache Felix was explicitly blocked and thus not distributed, resulting in a distribution without an OSGI runtime.

This PR brings the NetBeans base to current master (915296a97f2327153d3ad87c9fef2d0bc8586fbb) and removes Felix from the blocklist.

@matthiasblaesing

Copy link
Copy Markdown
Contributor Author

Only a start test was done: Bringing the embedded netbeans module to current master without updating the exclusion list creates a nbcode build that immediately fails on start:

java.lang.IllegalStateException: No NetigsoFramework found, is org.netbeans.core.netigso module enabled?
        at org.netbeans.NetigsoHandle.getDefault(NetigsoHandle.java:63)
        at org.netbeans.NetigsoHandle.turnOn(NetigsoHandle.java:115)
        at org.netbeans.ModuleManager.doEnable(ModuleManager.java:1488)
        at org.netbeans.ModuleManager.enable(ModuleManager.java:1343)
        at org.netbeans.ModuleManager.enable(ModuleManager.java:1266)
        at org.netbeans.core.startup.ModuleList.installNew(ModuleList.java:313)
        at org.netbeans.core.startup.ModuleList.trigger(ModuleList.java:249)
        at org.netbeans.core.startup.ModuleSystem.restore(ModuleSystem.java:294)
        at org.netbeans.core.startup.Main.getModuleSystem(Main.java:174)
        at org.netbeans.core.startup.Main.getModuleSystem(Main.java:143)
        at org.netbeans.core.startup.Main.start(Main.java:305)
        at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:97)
        at java.base/java.lang.Thread.run(Thread.java:1474)

Together with the update of the dependency list this now works (i.e. the process does not terminate).

@JaroslavTulach

Copy link
Copy Markdown
  • Thanks @matthiasblaesing for looking into the issue
    • thanks also for trying (to start) Apache NetBeans VSCode extension
    • btw. do you use VSCode occasionally (for non-Java development)?
  • Your fix is simple and can certainly mitigate the problem way simpler ...
  • then waiting for Updating Equinox to version 3.24.300 netbeans#9610
    • where I am still struggling to find my head around the concepts changed after the Equinox upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants