Fix snapshot pipe startup before IoTConsensus catch-up - #18534
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Snapshot/history-only Pipe sources use a heartbeat-only realtime source. With IoTConsensus, a Pipe task can start on a replica before writes from another writer have been asynchronously applied. The historical scan then sees no TsFiles, emits its terminate event, and allows the Pipe to be auto-dropped before the delayed writes arrive.
This change waits for all remote IoTConsensus writers to finish synchronizing their logs before a heartbeat-only DataRegion source begins historical extraction. The wait runs outside the DataRegion write lock so remote writes can still be applied. Other consensus protocols and realtime Pipe source modes retain the existing startup path.
Verification
mvn spotless:apply -pl iotdb-core/consensus,iotdb-core/datanode