feat(server): support native Windows builds - #4050
TalaatHarb wants to merge 2 commits into
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4050 +/- ##
============================================
+ Coverage 85.40% 85.53% +0.12%
Complexity 1402 1402
============================================
Files 1240 1240
Lines 186294 186213 -81
Branches 152600 152518 -82
============================================
+ Hits 159109 159279 +170
+ Misses 23132 22890 -242
+ Partials 4053 4044 -9
🚀 New features to boost your workflow:
|
|
looks like clippy is failing. please fix :) after that we can check. |
|
/author |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either Thank you for your contribution! |
Which issue does this PR address?
Closes #4037
Rationale
Provide the ability to build the system natively on windows os
What changed?
iggy-servercould not be built or run natively on Windows. The failure was not asingle blocker but a chain of them: build/runtime dependency issues and also Unix only syscalls in the storage and transport layers. This PR adds windows alternative for the Unix only syscalls and adds documentation of how to build iggy-server on windows.
Local Execution
due to the nature of this PR focusing on windows setup the behavior of the pre-commit hooks might not cover everything
AI Usage
Tools used: GitHub Copilo was used
Sope of usage: generated functions as alternatives for the Unix only issues
Verification: Build, Tests and basic runtime behavior verified after the modifications (This PR makes
cargo build -p server --bin iggy-serverproduce a working Windows binary that boots, serves traffic, shuts down gracefully, and recoversits data on restart which wasn't available before). Other OS targets behavior should be intact and verified through CI.
I can explain the logic behind every line of the code if asked.