Skip to content

refactor(sql): derive catalog configuration from properties #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blackmwk wants to merge 2 commits into
base: main
Choose a base branch
from
+192 −163
Open

refactor(sql): derive catalog configuration from properties #3105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4718d5b
refactor(sql): derive catalog configuration from properties
blackmwk Aug 28, 2026
5019a92
refactor(sql): centralize catalog properties
blackmwk Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/catalog/sql/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ repository = { workspace = true }
[dependencies]
async-trait = { workspace = true }
iceberg = { workspace = true }
iceberg-property-macro = { workspace = true }
sqlx = { version = "0.8.1", features = ["any"], default-features = false }
strum = { workspace = true }
tracing = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion crates/catalog/sql/public-api.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ pub fn iceberg_catalog_sql::SqlCatalogBuilder::sql_bind_style(self, sql_bind_sty
pub fn iceberg_catalog_sql::SqlCatalogBuilder::uri(self, uri: impl core::convert::Into<alloc::string::String>) -> Self
pub fn iceberg_catalog_sql::SqlCatalogBuilder::warehouse_location(self, location: impl core::convert::Into<alloc::string::String>) -> Self
impl core::default::Default for iceberg_catalog_sql::SqlCatalogBuilder
pub fn iceberg_catalog_sql::SqlCatalogBuilder::default() -> Self
pub fn iceberg_catalog_sql::SqlCatalogBuilder::default() -> iceberg_catalog_sql::SqlCatalogBuilder
impl core::fmt::Debug for iceberg_catalog_sql::SqlCatalogBuilder
pub fn iceberg_catalog_sql::SqlCatalogBuilder::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result
impl iceberg::catalog::CatalogBuilder for iceberg_catalog_sql::SqlCatalogBuilder
Expand Down
Loading
Loading