Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add a test for a transaction that adds a nullable column and appends a row, while another writer commits first.
The test checks that the first writer retries and keeps the new column, its field ID, and all three rows. It also checks the snapshot's parent and schema ID, and that reloading the table gives the same result.
Are these changes tested?
Yes. The new test passes for all three existing catalog fixtures.
make testpasses with 4,239 passed, 5 skipped, and 126 deselected on Python 3.12.make lintalso passes.Are there any user-facing changes?
No. This adds test coverage only.
AI-assisted implementation.