Skip to content

fix: add http:// prefix to server address in schema requests #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raled573343 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add http:// prefix to server address in schema requests #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vermeer/apps/common/hugegraph_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func testServerIsValid(serverAdds []string, hgSpace, hGraph, username, password
wg.Add(1)
go func(addr string, ctx context.Context, cancel context.CancelFunc) {
defer wg.Done()
url := fmt.Sprintf("%v/graphspaces/%v/graphs/%v/schema?format=json", addr, hgSpace, hGraph)
url := fmt.Sprintf("http://%v/graphspaces/%v/graphs/%v/schema?format=json", addr, hgSpace, hGraph)

@imbajin imbajin Sep 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This prefixes only the request URL but returns the original addr. FindServerAddr() stores that value in output.hugegraph_server (vermeer/apps/worker/compute_bl.go:518), and HugegraphWriter.Init() concatenates it into request URLs at vermeer/apps/graphio/hugegraph.go:568,591,633. With PD returning server:8080, the probe now succeeds as http://server:8080/... but write-back constructs server:8080/graphspaces/..., which http.NewRequest rejects because it has no valid HTTP scheme. The same unconditional prefixing turns a pre-schemed address into http://http://... or http://https://..., whereas the old code accepted such a base URL. Normalize the address once at discovery, preserve an existing http/https scheme, use the normalized base for both read and write paths, and add raw and pre-schemed coverage.

req, err := http.NewRequest(http.MethodGet, url, nil)
req.SetBasicAuth(username, password)

@bitflicker64 bitflicker64 Sep 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Optional, or a follow-up issue: req.SetBasicAuth here runs before the err check on line 184, so a http.NewRequest failure panics instead of returning. Pre-existing, but one line below your change and in the same function, so it may be cheapest to fix while reworking the address handling for imbajin's line 181 comment.

hgSpace/hGraph reach line 181 straight from SplitHgName of the task's hugegraph_name param, which splits on / and validates nothing else, so any ASCII control character in a graph name makes url.Parse fail and leaves req nil. On go1.23.7:

err=parse "http://server:8080/.../graphs/g\n/schema?format=json": net/url: invalid control character in URL
PANIC on req.SetBasicAuth: runtime error: invalid memory address or nil pointer dereference

This goroutine has no recover, so it takes the worker down rather than failing one probe. getHugegraphSchema repeats the ordering at lines 226-228.

Suggested change: move if err != nil above SetBasicAuth in both. getHugegraphSchema already logs and returns there; this closure has no return value, so log before the bare return.

if err != nil {
Expand Down Expand Up @@ -208,7 +208,7 @@ func GetHugegraphSchema(serverAddr, hgName, username, password string) (map[stri
logrus.Errorf("split hg name failed, %v", err.Error())
return nil, fmt.Errorf("split hg name failed, %v", err.Error())
}
url := fmt.Sprintf("%v/graphspaces/%v/graphs/%v/schema?format=json", serverAddr, hgSpace, hGraph)
url := fmt.Sprintf("http://%v/graphspaces/%v/graphs/%v/schema?format=json", serverAddr, hgSpace, hGraph)
// retry 3 times
var propertyFromHg map[string]any
for i := 0; i < 3; i++ {
Expand Down
Loading