Repository navigation
[rust] Tighten down internal API visibility to pub(crate) - #5062
Closed
VidyavathiGK wants to merge 1 commit into
Closed
VidyavathiGK wants to merge 1 commit into
VidyavathiGK wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Ported from apache/fluss-rust#665 (originally tracking apache/fluss-rust#377) into the monorepo following the repository consolidation.
Audits and restricts the visibility of internal-only structs, enums, traits, functions, and modules across
fluss-rust/crates/flusstopub(crate)to avoid exposing internal implementation details and risking backward-compatibility breaks once released.Brief change log
mod io;.RpcClient,ServerConnection,MessengerTransport,SaslConfig).WriteType,ReadType) topub(crate)while preservingpub use crate::rpc::message::OffsetSpec;.to_pb(),from_pb()) on metadata structs across partition, table, snapshot, and stats models topub(crate).InnerWriteBatch,ArrowLogWriteBatch,Sender,RecordAccumulator,BucketAssigner,RoundRobinBucketAssigner,HashBucketAssigner,ClientSchemaGetter,PartitionGetter) topub(crate).WriteResultFutureas the sole public write client return type.PendingFetch,LogFetchBuffer) andReadContextResolvermethods topub(crate).binary,columnar,compacted,encode,field_getter,paimon) topub(crate).ArrowRecordBatchInnerBuilder,MemoryLogRecordsArrowBuilder, and record batch header constants topub(crate).to_arrow_schema,to_arrow_type,from_arrow_field) and public scanner/reader types.FlussAdminAPIs instead of inspecting private connection cluster nodes.Verifying this change
This change is a code-refactoring / visibility hardening change.
Existing unit tests and integration tests continue to cover all functionality.
Does this pull request potentially affect one of the following?
pubdown topub(crate)before 0.1 release)