fix(planner): add missing flink-table-code-splitter test dependency - #29019
Open
shoemoney wants to merge 1 commit into
Open
fix(planner): add missing flink-table-code-splitter test dependency#29019shoemoney wants to merge 1 commit into
shoemoney wants to merge 1 commit into
Conversation
Fix verified RED->GREEN. Planner test compilation fails without flink-table-code-splitter test dependency at pom.xml:176 - JsonParseReuseTest.java:32 imports org.apache.flink.table.codesplit.JavaCodeSplitter but pom has no dependency on flink-table-code-splitter, any -Dtest=CreateConnectionITCase fails to compile
Collaborator
uros-b
approved these changes
Aug 29, 2026
Member
|
Good fix, thank you @shoemoney! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix a test compilation failure in the planner module.
JsonParseReuseTest.javaimportsorg.apache.flink.table.codesplit.JavaCodeSplitter, butflink-table/flink-table-planner/pom.xmldeclares no test-scoped dependency onflink-table-code-splitter, somvn -Dtest=CreateConnectionITCasefails to compile the test sources.Brief change log
flink-table-code-splittertoflink-table/flink-table-planner/pom.xmlVerifying this change
JsonParseReuseTest.javafails to compile without the dependencyDoes this pull request potentially affect one of the following parts:
flink-table-code-splitter@Public(Evolving): noDocumentation