Skip to content

fix(planner): add missing flink-table-code-splitter test dependency - #29019

Open
shoemoney wants to merge 1 commit into
apache:masterfrom
shoemoney:fix/planner-codesplitter-dep
Open

fix(planner): add missing flink-table-code-splitter test dependency#29019
shoemoney wants to merge 1 commit into
apache:masterfrom
shoemoney:fix/planner-codesplitter-dep

Conversation

@shoemoney

@shoemoney shoemoney commented Aug 25, 2026

Copy link
Copy Markdown

What is the purpose of the change

Fix a test compilation failure in the planner module. JsonParseReuseTest.java imports org.apache.flink.table.codesplit.JavaCodeSplitter, but flink-table/flink-table-planner/pom.xml declares no test-scoped dependency on flink-table-code-splitter, so mvn -Dtest=CreateConnectionITCase fails to compile the test sources.

Brief change log

  • Add a test-scoped dependency on flink-table-code-splitter to flink-table/flink-table-planner/pom.xml

Verifying this change

  • Confirmed the import in JsonParseReuseTest.java fails to compile without the dependency
  • Confirmed test compilation succeeds after adding it

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes, adds a test-scoped dependency on flink-table-code-splitter
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature?: no

Fix verified RED->GREEN. Planner test compilation fails without flink-table-code-splitter test dependency at pom.xml:176 - JsonParseReuseTest.java:32 imports org.apache.flink.table.codesplit.JavaCodeSplitter but pom has no dependency on flink-table-code-splitter, any -Dtest=CreateConnectionITCase fails to compile
@flinkbot

flinkbot commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@uros-b

uros-b commented Aug 29, 2026

Copy link
Copy Markdown
Member

Good fix, thank you @shoemoney!

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants