FINERACT-2846: Remove dead code block in TellerWritePlatformServiceJpaImpl - #6204
Open
prajakta128 wants to merge 1 commit into
Open
prajakta128 wants to merge 1 commit into
prajakta128 wants to merge 1 commit into
Conversation
prajakta128
force-pushed
the
remove-teller-dead-code
branch
from
July 31, 2026 05:27
518f05c to
f5a91dc
Compare
Contributor
|
@prajakta128 Please use the appropriate commit and PR title: Example: |
prajakta128
force-pushed
the
remove-teller-dead-code
branch
from
August 3, 2026 16:26
f5a91dc to
eae5f9c
Compare
Contributor
|
@prajakta128 Please rebase |
1 similar comment
Contributor
|
@prajakta128 Please rebase |
prajakta128
force-pushed
the
remove-teller-dead-code
branch
from
September 21, 2026 12:59
eae5f9c to
bd550cb
Compare
Contributor
|
Please use |
prajakta128
force-pushed
the
remove-teller-dead-code
branch
from
September 22, 2026 01:56
bd550cb to
605318b
Compare
prajakta128
force-pushed
the
remove-teller-dead-code
branch
from
September 22, 2026 02:01
605318b to
32eb9a8
Compare
prajakta128
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes an unreachable/no-op code block inside
doTransactionForCashier()inTellerWritePlatformServiceJpaImpl.java.Why
The block read an
entityTypeparameter from the request and branched on its value ("loan account", "savings account", "client"), but every branch was either empty or entirely commented-out code.entityTypewas never referenced again anywhere else in the method or the file, so the block had zero effect on runtime behavior. The originalauthor had already flagged it themselves:
java // TODO: can we please remove this whole block?!? this is 20 lines of dead code!!! This PR simply deletes that block. No behavior change.
JIRA
FINERACT-2846
Checklist
entityTypeis unused elsewhere in the fileJAVA_HOMEsetup; will confirm once CI runs / once resolved locally)