refactor: extract format-string date detection out of DateUtils - #1077
Open
nkuprins wants to merge 3 commits into
Open
refactor: extract format-string date detection out of DateUtils#1077nkuprins wants to merge 3 commits into
nkuprins wants to merge 3 commits into
Conversation
skytin1004
approved these changes
Sep 8, 2026
skytin1004
left a comment
Contributor
There was a problem hiding this comment.
I reviewed this locally and ran the relevant tests, which all passed.
I confirmed that the date detection logic was moved without changes and that the existing public methods still work through DateUtils. The cache cleanup test also confirms that DateUtils.removeThreadLocalCache() clears the cache in the new class.
Since this refactoring moves the date detection logic without changing its behavior, I think the existing tests provide sufficient coverage. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: #1062
Purpose of the pull request
As title
What's changed?
DateUtilsinto a dedicatedExcelDateFormatDetectorpackage-private class.DateUtilsTestto test date format detection via the newly extractedExcelDateFormatDetector.Checklist