[chore](build) Use ubuntu-slim for review trigger - #68048
Open
hello-stephen wants to merge 1 commit into
Open
hello-stephen wants to merge 1 commit into
hello-stephen wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: None Related PR: #68025 Problem Summary: The review-label trigger only runs an echo command to emit the workflow_run event, but it currently allocates a full ubuntu-latest VM. Use the lightweight ubuntu-slim container runner for this short automation task. ### Release note None ### Check List (For Author) - Test: Manual test - actionlint .github/workflows/approve-label-trigger.yml - git diff --check - Behavior changed: No. The pull_request_review and downstream workflow_run events are unchanged. - Does this need documentation: No
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
Contributor
Author
|
skip buildall |
Member
|
looks good. The restrictions are essentially 15min timeout and a limited set of pre-installed tools, see some of your other workflows look like that they only need gh CLI, jq and basic bash -> so there might be more candidates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Switch the lightweight
Label when reviewedtrigger job fromubuntu-latesttoubuntu-slim.The job only runs
echoto emit the downstreamworkflow_runevent, so the 1-vCPU container runner is a better fit than a full Ubuntu VM.Suggested by @mbien in #68025 (comment).
Validation
actionlint .github/workflows/approve-label-trigger.ymlgit diff --checkThe event wiring is unchanged:
pull_request_reviewstill starts this workflow, and the existingworkflow_run.requestedlistener remains unchanged. Runtime validation requires a review event after this change reaches the default branch.