Skip to content

branch-4.1: [fix](variant) Keep integer element_at indexes out of variant sub-column paths #67955 - #68041

Merged
eldenmoon merged 2 commits into
branch-4.1from
auto-pick-67955-branch-4.1
Sep 16, 2026
Merged

branch-4.1: [fix](variant) Keep integer element_at indexes out of variant sub-column paths #67955#68041
eldenmoon merged 2 commits into
branch-4.1from
auto-pick-67955-branch-4.1

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #67955

@github-actions
github-actions Bot requested a review from yiguolei as a code owner September 16, 2026 01:35
@hello-stephen

hello-stephen commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen hello-stephen reopened this Sep 16, 2026
@hello-stephen

hello-stephen commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

run buildall

@eldenmoon @claude
[test](variant) Run the integer element_at cases only on Variant V2
a350432 
On branch-4.1 enable_variant_v2 is off by default, and the legacy V1 path
resolves an integer index as an object key, so indexing an array stored in a
VARIANT column returns NULL there and the cherry-picked cases fail. Skip them
while V2 is off; the planner fix and its FE unit tests are unaffected.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@eldenmoon

eldenmoon commented Sep 16, 2026

Copy link
Copy Markdown
Member

run buildall

@hello-stephen

hello-stephen commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 11.11% (2/18) 🎉
Increment coverage report
Complete coverage report

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@eldenmoon
eldenmoon merged commit 7a21b13 into branch-4.1 Sep 16, 2026
36 of 39 checks passed
yiguolei pushed a commit that referenced this pull request Sep 17, 2026
@github-actions @yiguolei
branch-4.1: [fix](variant) Keep integer element_at indexes out of var…
4ba21d3 
…iant sub-column paths #67955 (#68041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen @eldenmoon @yiguolei