Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Predicate deletes only persist delete predicates and therefore cannot produce row-level DELETE events. A merge-on-write unique table with light delete enabled incorrectly used that path even when ROW binlog was enabled, leaving downstream consumers with stale rows. Route these deletes through row-bearing DELETE FROM USING execution, and reject any ROW-binlog predicate delete that still reaches the legacy handler.
### Release note
Ensure DELETE on merge-on-write unique tables with ROW binlog emits row-level DELETE events even when light delete is enabled. Predicate DELETE on ROW-binlog tables now reports an explicit unsupported error.
### Check List (For Author)
- Test: Regression test, FE unit test, and manual test
- Regression test: row_binlog_p0/test_row_binlog_mow_light_delete
- Unit Test: org.apache.doris.nereids.trees.plans.commands.DeleteFromCommandTest
- Manual test: verified ROW binlog DELETE events with historical values disabled and enabled
- Behavior changed: Yes; MOW ROW-binlog deletes use row-bearing execution, while unsupported predicate deletes fail explicitly
- Does this need documentation: No
luwei16
requested review from
924060929,
englefly,
gavinchou,
liaoxin01,
morrySnow and
starocean999
as code owners
September 15, 2026 17:05
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
gavinchou
approved these changes
Sep 15, 2026
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
/review |
Contributor
|
Codex automated review failed and did not complete. Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Sep 19th, 2026 8:24 AM. The selected account is excluded until 2026-09-19T08:24:00Z. Please trigger /review again; another configured account may be available. |
morrySnow
approved these changes
Sep 16, 2026
Contributor
Author
|
run performance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Predicate deletes only persist delete predicates and therefore cannot produce row-level DELETE events. A merge-on-write unique table with light delete enabled incorrectly used that path even when ROW binlog was enabled, leaving downstream consumers with stale rows. Route these deletes through row-bearing DELETE FROM USING execution, and reject any ROW-binlog predicate delete that still reaches the legacy handler.
Release note
Ensure DELETE on merge-on-write unique tables with ROW binlog emits row-level DELETE events even when light delete is enabled. Predicate DELETE on ROW-binlog tables now reports an explicit unsupported error.
Check List (For Author)