Conversation
mihaibudiu
reviewed
Sep 17, 2026
| } | ||
|
|
||
| /** | ||
| * Returns whether an UNNEST call's array operand has a struct element type. |
Contributor
There was a problem hiding this comment.
beware that unnest has two semantics, depending on conformance: the Trino semantics does not create a column for each ROW column, and the standard semantics does.
Contributor
Author
There was a problem hiding this comment.
Oh, I was not aware. Thank you for catching that.
mihaibudiu
approved these changes
Sep 19, 2026
mihaibudiu
added
the
LGTM-will-merge-soon
Contributor
|
I think you can squash the commits for merging |
…e when aliased Extend AliasNamespace's CALCITE-5779 COLLECTION_TABLE check to also cover UNNEST when the array's component type is a struct. With allowAliasUnnestItems=true (Trino), UNNEST does not expand struct columns and instead uses the alias directly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e when aliased
Extend AliasNamespace's CALCITE-5779 COLLECTION_TABLE check to also cover UNNEST when the array's component type is a struct
Jira Link
CALCITE-7791