ATLAS-5408: Fix hook import classpath and logging issues in docker envs - #760
Merged
Merged
Conversation
HBase: ship commons-configuration 1.x in atlas-hbase-plugin-impl because import-hbase.sh excludes it from HBase lib while Hadoop still needs it when HADOOP_HOME/classpath is absent. Logging: create /var/log/atlas in atlas-base and mkdir -p ATLAS_LOG_DIR in import-hbase, import-hive, and import-kafka so logback can open import logs. Kafka: stop putting broker config and log4j jars on the import classpath to avoid broker log4j.properties writing to /server.log; default KAFKA_CONF to $KAFKA_HOME/config. Co-authored-by: Cursor <cursoragent@cursor.com>
mneethiraj
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBase: ship commons-configuration 1.x in atlas-hbase-plugin-impl because import-hbase.sh excludes it from HBase lib while Hadoop still needs it when HADOOP_HOME/classpath is absent.
Logging: create /var/log/atlas in atlas-base and mkdir -p ATLAS_LOG_DIR in import-hbase, import-hive, and import-kafka so logback can open import logs.
Kafka: stop putting broker config and log4j jars on the import classpath to avoid broker log4j.properties writing to /server.log; default KAFKA_CONF to $KAFKA_HOME/config.
What changes were proposed in this pull request?
How was this patch tested?
Test plan
Rebuild: mvn -pl addons/hbase-bridge,addons/kafka-bridge -am package -DskipTests -Drat.skip=true; rebuild docker images with new hook tarballs and atlas-base.
HBase: create a table, run import-hbase.sh with Atlas URL/credentials.
Hive: run import-hive.sh (smoke).
Kafka: run import-kafka.sh against running broker; confirm clean startup banner, no log4j root-file errors.
Confirm log files under /var/log/atlas/.