Repository navigation
fix: fresh-app DX follow-ups to 0.0.46 (#929–#933) - #936
Merged
Merged
Conversation
Right after a release uv's cached simple index can predate the CLI's own pins, so the first sync fails to resolve published packages. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…ts (#931) smpy add only changes host/pyproject.toml, so nothing reloads and the new module 404s until a restart. create-module's hint now says `uv run smpy add`, and both commands suggest the same migration message. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
uvicorn's reloader watches only *.py, so editing locales/en.json under make dev did nothing until a restart. The landing page's commands now say `uv run smpy` as well. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…foreign smpy (#929) A plain uv sync at the app root uninstalled the CLI, so `uv run smpy` fell through to an older global smpy. Inside an app, smpy now warns when the app pins another framework version, and doctor names the wrong smpy instead of saying to run it inside a project. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…and doctor (#933) make_process_revision_directives now ignores SQLAlchemy's and Alembic's warnings about the expression indexes the models declare: the hook already re-emits them for new tables and names any the database lacks. SM026 and the boot-time note report only indexes the SQLite file does not have. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
8119a97
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29177e1d.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issues-929-933.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five problems a new user hits on a fresh 0.0.46 app, going
smpy new→create-module→smpy add→make dev. Each issue has its own commit.uv syncuninstalls the CLI. The app template's root[dependency-groups] devnow pinssimple_module_cli==<version>, souv run smpykeeps using the app's own CLI. Inside a project,smpynow warns when the project pins the framework to another version than its own.new,updateandpackage-updateare exempt, since they change versions on purpose.smpy doctorrun by a CLI outside the project's venv now says so, instead of "run it inside a project".make dev.dev-apiin the workspace and flat app templates, and in this repo's Makefile, now passes--reload-include '*locales/*.json'. Without it uvicorn watches only*.py. A reload re-runs the dev boot, which regenerates the i18n keys.smpy addnow ends with "Ifmake devis running, restart it".add <name>, the same messagecreate-modulesuggests.create-module's next steps and the landing page sayuv run smpy.smpy newretries a failinguv synconce with--refreshand says why. Only a second failure prints uv's output.make_process_revision_directives, which every app'senv.pyalready calls, now ignores SQLAlchemy's and Alembic's warnings about the expression indexes the models declare. The revision hook already handles those indexes.sqlite3in read-only mode.Design:
docs/superpowers/specs/2026-11-13-issues-929-933-design.md. Plan:docs/superpowers/plans/2026-11-13-issues-929-933.md.Verification
make lint✅PYTEST_WORKERS=8 make test-py✅ (8488 passed, 49 skipped)make test-js✅ (909 passed)uv sync,uv run which smpy→.venv/bin/smpy.make dev-api, writinglocales/en.jsontriggered "Reloading…", and editingpackage.jsondid not.alembic check: 4 expression-index warning lines on main, 0 on the branch.fix: address code review findings (round 1, pass 1); pass 2 changed only docs.Test plan
dev-apiflag.Closes #929
Closes #930
Closes #931
Closes #932
Closes #933
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4