Repository navigation
fix(release): remove the module-layout aliases due in 0.0.46 - #927
Merged
Merged
Conversation
The 0.0.46 release failed at the post-bump deprecation expiry gate: 67 module-layout compat aliases (and the three alias-only endpoints packages) carried remove_in="0.0.46", as the CHANGELOG had promised. Delete them, point the auth and module-layout docs at the current paths, and record the removal under [Unreleased]. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
bc133df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b364be4d.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-release-remove-046-layou.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release run 43473183566 failed in
build→ Deprecation expiry gate (post-bump): after bumping to 0.0.46,host/tests/test_deprecation_expiry.py::test_no_shim_outlives_its_remove_in_releasefound 67 module-layout aliases withremove_in="0.0.46". The gate did what it's meant to do: the CHANGELOG had promised these paths would go in 0.0.46.What
deprecated_module+sys.modulesalias files, plus the docstring-onlyendpoints/__init__.pypackages inbranding,settingsandsharingthat only existed to hold them. Thesettings._secrets/settings.constants/settings.storealiases have a laterremove_in, so they stay.docs/modules/auth.mdnow says the oldauth.*paths are gone.docs/module-layout.mdno longer hard-codes 0.0.46 as the removal release for future moves.CHANGELOG.md[Unreleased]→### Removedlists every removed path (marked as a behaviour change).No code in this repo imported the old paths (I checked with git grep). The only matches are historical plans, logger names and the frozen durable wire name
file_storage.tenant_deletion, which are strings and still work.Verification
expired_deprecations("0.0.46")and("0.0.47")are both empty after the change.make lint✅,make test-py✅ (8464 passed, 48 skipped),make ci-doctor✅.After merge, re-run the release workflow.
https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4