Repository navigation
fix(cli): generated module pages read their locale file (#918) - #926
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
28205cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14fe02ad.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-918-keyed-module-p.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browse,CreateandEditpages are now the base module templates. Before this, only the in-repoframework_repooverlay had them.t(keys.<module>.…)anduseApiErrorToast.smpy create-moduleinside an app, andsmpy new's samplehellomodule, now read their text fromlocales/en.json.--standalonemodule repos (_optional/standalone/), which have no host to generatekeys.keysis a static object, and the app'stscdoes not check module pages. On a real scaffolded app,npm run buildpassed beforegen-i18nwithkeys.helloundefined, so the pages would have crashed at runtime. Three places now rungen-i18nbefore the frontend build:make builddepends ongen-pagesandgen-i18n, in both app Makefiles;npm run build;smpy module verify.t(keys.orders…)), module-authoring, thescaffolding.pydocstring, CLAUDE.md, thesimple-module-creatingskill and the CHANGELOG.Closes #918
Verification
make lint,make test-py(8484 passed),make test-js(909 passed) all green.en.json; the Dockerfiles and Makefiles rungen-i18nbefore the build; andsmpy module verifyruns its steps in order.Test plan
smpy new demo --yes,make build: the hello pages render theiren.jsontexthttps://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4