Repository navigation
fix(db): warn only about expression indexes a SQLite revision misses; quieter smpy new (#917) - #925
Merged
Merged
Conversation
… app-appropriate advice (#917) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
c0baefd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58e6a3b8.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-917-expression-ind.simple-module-python.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlite_master, which SQLite records even though it cannot reflect their definitions.ix_users_user_email_lower, and any unrelated revision.SM026and in themigratenote comes from one helper,expression_index_advice.make migrations-roundtrip-pgonly where the Makefile defines that target.make migrate, thenalembic check, against a PostgreSQLSM_DATABASE_URL, and links the docs.smpy newchanges:uv sync,npm installand alembic output and shows it only when a step fails.Closes #917
Verification
smpy new demo --yes: short output, next steps at the end, initial schema created.make lint,make test-py(8481 passed),make test-js(909 passed) all green.Test plan
make migrationon a migrated SQLite dev DB prints no expression-index bannerhttps://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4