Repository navigation
fix(cli): keep a smpy new app installed under uv; say restart for modules added during make dev (#916, #915) - #924
Merged
Conversation
…r modules added during make dev (#916, #915) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
67c2226
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a426db9.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-915-916-app-instal.simple-module-python.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smpy newapp stays installed under plain uv commands.<app>-hostthrough a{ workspace = true }source, souv syncat the root installs the app instead of uninstalling it.smpy add … --path hostinside an app syncs the whole workspace from the root (uv sync --all-packages, likemake install) instead of syncinghost/alone, which dropped the root's dev tools and the other modules.smpy newinstalls withuv sync --all-packages, and--no-installprintsmake install.smpy create-moduleinside an app prints the app flow (smpy add,make install,make migration,make migrate,make test, restartmake dev) instead ofuv sync --extra devinside the module.make devruns is logged as "installed but '' cannot be imported in this process … restart the server (make dev)" without a traceback. Strict discovery still refuses it, and a missing third-party import keeps its traceback.simple-module-cliandsimple-module-creatingskills, and the CHANGELOG.Closes #916
Closes #915
Verification
uv syncat the root installed the modules.smpy add ../modules/notes --path hostleft pytest, ruff, hello and notes installed.create-moduleprinted the app flow.make lint,make test-py(8469 passed),make test-js(909 passed) all green.Test plan
smpy new demo --yes --no-install, then a plainuv syncat the root installs the apphttps://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4