Skip to content

fix(cli): keep a smpy new app installed under uv; say restart for modules added during make dev (#916, #915) - #924

Merged
antosubash merged 5 commits into
mainfrom
fix/issue-915-916-app-install
Nov 12, 2026
Merged

antosubash merged 5 commits into
mainfrom
fix/issue-915-916-app-install

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

  • workspace: create-module's next steps and a plain uv sync uninstall the app's modules from the shared venv #916: a smpy new app stays installed under plain uv commands.
    • The workspace root depends on <app>-host through a { workspace = true } source, so uv sync at the root installs the app instead of uninstalling it.
    • smpy add … --path host inside an app syncs the whole workspace from the root (uv sync --all-packages, like make install) instead of syncing host/ alone, which dropped the root's dev tools and the other modules.
    • smpy new installs with uv sync --all-packages, and --no-install prints make install.
    • smpy create-module inside an app prints the app flow (smpy add, make install, make migration, make migrate, make test, restart make dev) instead of uv sync --extra dev inside the module.
  • dev: a module added while make dev runs fails to load ("No module named '<name>.module'") until a full restart #915: a module installed while make dev runs is logged as "installed but '' cannot be imported in this process … restart the server (make dev)" without a traceback. Strict discovery still refuses it, and a missing third-party import keeps its traceback.
  • Docs updated: quickstart, installation, first-module, make-commands, the workspace README template, the simple-module-cli and simple-module-creating skills, and the CHANGELOG.

Closes #916
Closes #915

Verification

  • End to end on a freshly scaffolded app: a plain uv sync at the root installed the modules. smpy add ../modules/notes --path host left pytest, ruff, hello and notes installed. create-module printed the app flow.
  • Local CI: make lint, make test-py (8469 passed), make test-js (909 passed) all green.
  • Reviewed by two Sonnet reviewers (correctness and maintainability, 2 passes) and Codex (no findings).
  • Verification report: https://claude.ai/artifact/83GM9FtxXDzyQvxf73UimM · /ship report: https://claude.ai/artifact/1VdMc2w5RPT4Vsj88oJdYd

Report links are Claude Artifacts and start private — the author can share them
from claude.ai/code/artifacts if reviewers need access.

Test plan

  • smpy new demo --yes --no-install, then a plain uv sync at the root installs the app
  • CI is green

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 67c2226
Status: ✅  Deploy successful!
Preview URL: https://7a426db9.simple-module-python.pages.dev
Branch Preview URL: https://fix-issue-915-916-app-instal.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-12T15:33:12.848899Z 67c2226 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@antosubash
antosubash merged commit d7f2e4c into main Nov 12, 2026
16 checks passed
@antosubash
antosubash deleted the fix/issue-915-916-app-install branch November 12, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant