Skip to content

fix(hosting): serve /admin in every app; fix the quickstart (#914, #919) - #923

Merged
antosubash merged 7 commits into
mainfrom
fix/issue-914-919-admin-overview
Nov 12, 2026
Merged

antosubash merged 7 commits into
mainfrom
fix/issue-914-919-admin-overview

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

  • /admin now works in apps made by smpy new. The admin overview moved from this repo's host into simple_module_hosting.admin_overview (route + Admin/Overview page), mounted by create_app and registered by gen-pages exactly like the /setup wizard. Admission is unchanged. Strings moved host.admin.* → hosting.admin.*.
  • framework_assets() returns both framework frontends; gen-pages refuses a module whose ModuleMeta.name is Admin or Setup (it would silently lose its pages).
  • Quickstart and installation guides match a new app: anonymous curl /api/orders is 401, the single-file test path is real, and create-admin is shown without --password (it prompts). Same password fix in README, make-commands, users.md and the CLI skill.

Closes #914
Closes #919

Verification

  • Local CI: make lint, make test-py (8459 passed), make test-js (909 passed) all green
  • Reviewed by two Sonnet reviewers (correctness, maintainability; 3 passes) and Codex (no findings)
  • Verification report: https://claude.ai/artifact/7P6N4Rbr8C657YPVzhJyYo

Report links are Claude Artifacts and start private — the author can share them
from claude.ai/code/artifacts if reviewers need access.

Test plan

  • In a fresh smpy new app, sign in as admin and open /admin: the overview lists the admin tools
  • CI is green

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: bcc1a05
Status: ✅  Deploy successful!
Preview URL: https://7ebb9947.simple-module-python.pages.dev
Branch Preview URL: https://fix-issue-914-919-admin-over.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-12T15:07:31.708019Z bcc1a05 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@antosubash
antosubash merged commit 444d1cb into main Nov 12, 2026
16 checks passed
@antosubash
antosubash deleted the fix/issue-914-919-admin-overview branch November 12, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant