029 co2 savings dashboard - #81
Merged
Merged
Conversation
Add calculateCo2Saved pure function and Co2PerMileLbs constant to the F# domain calculations, wire the new Co2Saved and Co2SavedPerMileLbs fields through the API contracts and GetAdvancedDashboardService, and surface the CO2 savings in the frontend SavingsWindowsTable and advanced dashboard page (types, column, per-mile caption). Includes backend unit tests (AdvancedDashboardCalculationsTests, GetAdvancedDashboardServiceTests), frontend unit tests (SavingsWindowsTable, advanced-dashboard-page), and extended e2e coverage in savings-calculation.spec.ts, following TDD. Completes tasks T001-T023 in specs/029-co2-savings-dashboard/tasks.md.
Co2SavedPerMileLbs had a redundant '= 0.90m' default value in AdvancedDashboardContracts.cs, duplicating the single source of truth (AdvancedDashboardCalculations.Co2PerMileLbs). If the emission factor were ever changed there, this default would silently go stale. Made the parameter required (moved before the optional DifficultySection parameter to satisfy C# ordering rules) so callers must always supply it explicitly from the F# constant. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.