Repository navigation
docs: add attribute-based controls example - #43
Open
jasmine-ab-tea wants to merge 5 commits into
Open
jasmine-ab-tea wants to merge 5 commits into
jasmine-ab-tea wants to merge 5 commits into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
4 tasks done
Card links check✅ No broken Card links found. Checked external links in 0.6s |
✅ Markdown Lint PassedAll markdown files meet the linting standards! 🎉 |
- Warn that the decorator path needs step_types ["tool"] and the input.jurisdiction selector. - Show the strict default as a full control, and say it must stay in sync with the country controls. - Document step_type and tools in the @control() SDK reference. - Describe the PASS/FAIL output of the example scripts. Co-Authored-By: Claude <noreply@anthropic.com>
- New section on baseline vs country controls, with a baseline control. - Explain copying an x-ai-jurisdiction header into step.context. - Add the baseline scenarios to the scenario table. Co-Authored-By: Claude <noreply@anthropic.com>
- Remove the list indent inside <Warning> (MD007). - State that evaluation stops after the first deny match. - Narrow the header sentence: headers are not mapped into the step. - Add the no-jurisdiction + IBAN scenario. Co-Authored-By: Claude <noreply@anthropic.com>
jasmine-ab-tea
commented
Nov 5, 2026
jasmine-ab-tea
left a comment
jasmine-ab-tea
left a comment
Author
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-5-5). It may contain mistakes.
Verdict: approve — Commit f5dc283 fixes all round-2 items. They match agent-control PR #302 head f7e4d1b, and every CI check passes.
Addressed before this review
- An over-indented list inside the decorator-path
<Warning>failed Markdown Lint Check (MD007 atexamples/country-controls.mdx:94-95). Fixed in f5dc283. Markdown Lint Check now passes.
Co-Authored-By: Claude <noreply@anthropic.com>
jasmine-ab-tea
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: SAO-17024
Summary
This PR adds the docs page for the attribute-based controls example in agentcontrol/agent-control#302. The page teaches a general pattern, a rule that applies only for some values of a request attribute, with the country (jurisdiction) as the worked example.
examples/attribute-based-controls.mdx. It covers:step.context(recommended): Python SDK and rawPOST /api/v1/evaluation.@control()argument, for tool steps only.x-ai-jurisdictionrequest header intostep.context.jurisdiction.examples/overview.mdxunder "Use case examples".docs.json.sdk/python-sdk.mdx: document thestep_typeandtoolsparameters of@control(). The new page usesstep_type.Test plan
docs.jsonparses as valid JSON.is_safe: falseagainst a local server with the example controls.The source link points at
examples/attribute_controlsonmain. It resolves after agentcontrol/agent-control#302 merges, so merge that PR first.Related PRs
examples/attribute-based-controlscionmain(galileo-core 4.6HttpSpanmypy error), needed for this PR'sci🤖 Generated with Claude Code