Repository navigation
fix(compat): support Java 25 unordered event delivery in context tests - #6
Merged
Merged
Conversation
CI run 41759271776 read the second call's userIntent from events.get(0). EventQueue sends on concurrent workers, so capture order is not call order. Match both multi-call context tests by msg and cover reversed delivery without changing production behavior or the matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing
Java 25in CI #15, scheduled on main at2026-11-04T02:13:04Z.79d7308b8a6b578f51e16c0403b0e199230f6cbe.Cause
ContextParametersTestassumes capture order matches invocation order, butEventQueuepublishes through up to five concurrent workers.The second call can arrive first, so positional assertions inspect the wrong event.
Evidence
2026-11-04T02:13:37.3067711Z:org.opentest4j.AssertionFailedError: userIntent must be null when no context is provided ==> expected: <null> but was: <Listing todos to check current status>.ContextParametersTest.capturesUserIntentOnlyWhenContextProvided, line 250, after selectingevents.get(0).EventQueue.java:65,205-226starts separate workers;EventCapture.java:60,89-91records arrival order.25.0.5+8, and runner agent2.338.2.20261025.353.1to20261101.360.1; no demonstrated upstream MCP or JDK regression.Change
msgargument, independently ofuserIntent.Test / Verification
git diff --check: passed.command -v javaandcommand -v mvn: unavailable.mvn --batch-mode --no-transfer-progress verifyon Java 17, 21, and 25.mvn --batch-mode --no-transfer-progress clean compile, thenmvn --batch-mode --no-transfer-progress test -P<mcp-profile>.mvn --batch-mode --no-transfer-progress package -P release,mcp-2.0.1 -DskipTests -Dgpg.skip.910cd9c8b119fc869841046655019bb37e96a2c1.ContextParametersTest: 10 tests, 0 failures, 0 errors, 0 skipped.gh pr checks 6 --repo agentcathq/agentcat-java-sdk --watch: passed; all 14 reported results passed.Thread
No Slack permalink supplied; the originating alert links to CI #15.