Add the crash reason and timestamp to the ActorStatus - #1867
Open
Luiz Oliveira (laoj2) wants to merge 1 commit into
Open
Luiz Oliveira (laoj2) wants to merge 1 commit into
Luiz Oliveira (laoj2) wants to merge 1 commit into
Conversation
Luiz Oliveira (laoj2)
requested review from
Julian Gutierrez Oschmann (juli4n) and
Zoe Zhao (zoez7)
September 24, 2026 20:09
| // ateletCrashMessage describes a failed atelet call with the error text atelet | ||
| // returned, since its gRPC code is Unknown for most failures. | ||
| func ateletCrashMessage(rpc string, err error) string { | ||
| return fmt.Sprintf("atelet %s: %s", rpc, status.Convert(err).Message()) |
Collaborator
Author
There was a problem hiding this comment.
note that we're exposing the bare error from atelet here. Perhaps we should just write the rpc status code? (they're mostly Unknown though).
Luiz Oliveira (laoj2)
dismissed
Zoe Zhao (zoez7)’s stale review
via
September 25, 2026 01:43
58dbe5b
Luiz Oliveira (laoj2)
force-pushed
the
crash-reason
branch
from
September 25, 2026 01:43
6b49ca6 to
58dbe5b
Compare
Collaborator
Author
|
Rebased |
Luiz Oliveira (laoj2)
force-pushed
the
crash-reason
branch
from
September 25, 2026 01:50
58dbe5b to
d12d466
Compare
Zoe Zhao (zoez7)
enabled auto-merge
September 25, 2026 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new field to actor status that has the crash reason (e.g., the atelet response error) and the timestamp of the crash for better UX.