catchup PR WIP - #183
Open
ladyada wants to merge 418 commits into
Open
catchup PR WIP#183ladyada wants to merge 418 commits into
ladyada wants to merge 418 commits into
Conversation
Adapted the MCU table description with to the actual pinout
Modified the nano 33 Iot variant
…is given by the R28
Added SDA and SCL variables in variant.h of samd boards This resolve: #473
added define for PMIC_IRQ pin where needed
Added I2S definitions for NANO 33 IoT
Publish 1.8.5
fix example to support nano_33_iot
Fix SD SPI1 description on MKRZERO's variat fix: #500
Fix comment on sd SPI MKRZERO
This regex would only look at the .text section, but the .data section (initialization values for global variables) also takes up space in flash. The regex is changed to match both sections. arduino-builder will then add together the values and show the sum to the user (this summing seems to have been supported at least since the introduction of arduino-builder, see: arduino/arduino-builder@0802e27 The regex format is copied from the AVR core, which already did the same (though AVR also includes a .bootloader section, which is not relevant here it seems, any bootloader is included in .text). This also copies the start-of-line ^ anchor to the regex, making the matching more accurate.
This was previously omitted, causing arduino-builder to not report the amount of RAM used. This adds the regex, based on the regex used by AVR (omitting the .noinit section, which is not supported by the SAMD linker scripts).
Fix flash size regex and add RAM size regex
This is not LED_BLUE, it is SAM_INT_OUT, as seen in [VidorFPGA pin assignments](https://github.com/vidor-libraries/VidorFPGA/blob/master/constraints/MKRVIDOR4000/vidor_s_pins.qsf#L236) which connects to FPGA pin N2.
Correct MKR Vidor 4000 PB09 notes
I've updated the comments here to refer to "gclk" instead of generator x. Also added a spin to wait for the write to clear, just like what's done in `startup.c`.
Platform properties may be associated with a specific programmer selection in the programmers.txt configuration file. These properties can be used in the platform.txt patterns for the actions that use the programmer: - `program` - `erase` - `bootloader` However, those properties are not expanded in the `upload` pattern, since it does not use the programmer: https://arduino.github.io/arduino-cli/dev/platform-specification/#programmerstxt > These properties can only be used in the recipes of the actions that use the programmer (erase, bootloader, and program). While enhancing the ability to make programmer-specific configuration of the patterns, programmer-associated properties were introduced into `tools.openocd.upload.pattern`, which caused uploads to fail for the "Arduino Zero (Programming Port)" board: ``` Unexpected command line argument: {extra_params} ``` The upload pattern is hereby reverted to the previous working configuration, leaving the beneficial changes to the other patterns.
Remove programmer properties from openocd upload pattern
Fix legacy `upload.network_pattern` rules
As suggested by @thiagoralves
The "SimpleTone" example of the I2S bundled library uses a Maxim Integrated MAX98357 amplifier. This part was incorrectly referred to as "MAX08357" in the comments, which is corrected here. Reference: https://www.maximintegrated.com/en/products/analog/audio/MAX98357A.html
* Fix #661 * connected() did not return the USB connected state, but essentially a random value.
Fix USBDevice.connected()
Make SerialCDC inherit from HardwareSerial
Add missing #define statements when compared to AVR library. Support for readbytes with a byte/uint8_t buffer
This is usually not a problem becuase we use the arm-none-eabi-gcc compiler thas has type `uint32_t` aliased to `unsigned long`. Anyway this is not mandatory in general, and the compiler may choose to alias `uint32_t` with `unsigned int` as it happens with llvm/clang. Since we use clangd as language server on the Arduino IDE 2.0 the Serial_ object and all the derived instances (Serial, SerialUSB, ...) are not available in code-completion suggestions.
* Document how to add the required link to ArduinoCore-API. Related to arduino/ArduinoCore-API#96. * Update README.md Co-authored-by: per1234 <accounts@perglass.com> * Update README.md Co-authored-by: per1234 <accounts@perglass.com> * Update README.md Co-authored-by: per1234 <accounts@perglass.com> * Update README.md Co-authored-by: per1234 <accounts@perglass.com> Co-authored-by: per1234 <accounts@perglass.com>
…ition Arduino board definitions may associate unique properties of a port. These are used by convenience features in the Arduino development tools that identify a port as a specific Arduino board. In the case of boards that connect to the host computer via a virtual COM port, that identifier is the USB VID/PID pair. This association should only be done with properties that are unique to the board. For most official Arduino boards, this is possible because Arduino creates dedicated VID/PID pairs for that product. In the case of the Tian, a general purpose Silicon Labs CP2105 chip was selected as the USB interface. The board has the manufacturer supplied VID/PID pair 10C4:EA70. In this case it is irresponsible to associate that VID/PID pair with a board definition because any arbitrary device might have this VID/PID. The ports list will be confusing for users who have a CP2105 connected to their computer (whether it is on a 3rd party board or some other unrelated hardware).
I2S.cpp configures the clock without specifying what to GLCK->DIVSEL bit. This causes issues when the bit is set to 1 by other libraries such as RTCZero. Explicitly setting this value fixes the problem.
Update I2S.cpp to work with RTCZero library
Updated some names of MKR boards, see changes! @facchinm
Updated some naming of the products @facchinm
Updated naming of boards
Updated naming of MKR boards
USB CDC: Line Info Per Instance
Fix variant docs Issue #507
Correct MAX98357 part number in I2S library example
Remove inappropriate CP2105 VID/PID association from Tian board definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.