ci: Allow rebuilding dist/ for development dependencies - #476
Open
tingx2wang wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Dependabot dist/ rebuild workflow so that direct dependency bumps for both production and development dependencies can trigger rebuilding and artifact upload, ensuring generated bundles stay in sync across more Dependabot updates.
Changes:
- Broadened the workflow’s intent/comments from production-only to dependency bumps that can affect the bundle.
- Expanded step gating logic so
direct:developmentdependency updates are treated likedirect:productionfor rebuild/install/bundle/diff detection.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/rebuild-dist.yml | Expands Dependabot dependency-type gating to include direct development dependency bumps for dist/ rebuilds |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (4)
.github/workflows/rebuild-dist.yml:39
- The step
if:uses|(literal) which keeps newline characters in theifexpression. To avoid potential expression parsing issues, use a folded scalar (>-) so the expression is evaluated as a single logical line.
if: |
steps.meta.outputs.dependency-type == 'direct:production' ||
steps.meta.outputs.dependency-type == 'direct:development'
.github/workflows/rebuild-dist.yml:56
- This step uses
if: |which preserves line breaks inside the GitHub Actions expression string. Use a folded block (>-) so the condition is treated as a single expression without embedded newlines.
if: |
steps.meta.outputs.dependency-type == 'direct:production' ||
steps.meta.outputs.dependency-type == 'direct:development'
.github/workflows/rebuild-dist.yml:50
- This
if:condition is defined with a YAML literal block (|), which preserves newlines in the expression. Prefer>-(folded) so the expression doesn't include newline characters.
if: |
steps.meta.outputs.dependency-type == 'direct:production' ||
steps.meta.outputs.dependency-type == 'direct:development'
.github/workflows/rebuild-dist.yml:63
- Using
if: |keeps literal newlines in theifexpression; this can cause the condition to fail to parse/evaluate as intended. Use>-to fold the multi-line expression into a single line.
if: |
steps.meta.outputs.dependency-type == 'direct:production' ||
steps.meta.outputs.dependency-type == 'direct:development'
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: tingx2wang <17136661+tingx2wang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
.github/workflows/rebuild-dist.ymlworkflow to ensure that both production and development direct dependency bumps from Dependabot trigger a rebuild of thedist/directory. Previously, only production dependency bumps would trigger this process.