Skip to content

ci: Allow rebuilding dist/ for development dependencies - #476

Open
tingx2wang wants to merge 2 commits into
mainfrom
tingx2wang/rebuild-dist-for-dev-deps
Open

ci: Allow rebuilding dist/ for development dependencies#476
tingx2wang wants to merge 2 commits into
mainfrom
tingx2wang/rebuild-dist-for-dev-deps

Conversation

@tingx2wang

Copy link
Copy Markdown
Contributor

This PR updates the .github/workflows/rebuild-dist.yml workflow to ensure that both production and development direct dependency bumps from Dependabot trigger a rebuild of the dist/ directory. Previously, only production dependency bumps would trigger this process.

Copilot AI lite review requested due to automatic review settings August 21, 2026 22:11
@tingx2wang
tingx2wang requested a review from a team as a code owner August 21, 2026 22:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Dependabot dist/ rebuild workflow so that direct dependency bumps for both production and development dependencies can trigger rebuilding and artifact upload, ensuring generated bundles stay in sync across more Dependabot updates.

Changes:

  • Broadened the workflow’s intent/comments from production-only to dependency bumps that can affect the bundle.
  • Expanded step gating logic so direct:development dependency updates are treated like direct:production for rebuild/install/bundle/diff detection.
Show a summary per file
File Description
.github/workflows/rebuild-dist.yml Expands Dependabot dependency-type gating to include direct development dependency bumps for dist/ rebuilds

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Suppressed comments (4)

.github/workflows/rebuild-dist.yml:39

  • The step if: uses | (literal) which keeps newline characters in the if expression. To avoid potential expression parsing issues, use a folded scalar (>-) so the expression is evaluated as a single logical line.
        if: |
          steps.meta.outputs.dependency-type == 'direct:production' ||
          steps.meta.outputs.dependency-type == 'direct:development'

.github/workflows/rebuild-dist.yml:56

  • This step uses if: | which preserves line breaks inside the GitHub Actions expression string. Use a folded block (>-) so the condition is treated as a single expression without embedded newlines.
        if: |
          steps.meta.outputs.dependency-type == 'direct:production' ||
          steps.meta.outputs.dependency-type == 'direct:development'

.github/workflows/rebuild-dist.yml:50

  • This if: condition is defined with a YAML literal block (|), which preserves newlines in the expression. Prefer >- (folded) so the expression doesn't include newline characters.
        if: |
          steps.meta.outputs.dependency-type == 'direct:production' ||
          steps.meta.outputs.dependency-type == 'direct:development'

.github/workflows/rebuild-dist.yml:63

  • Using if: | keeps literal newlines in the if expression; this can cause the condition to fail to parse/evaluate as intended. Use >- to fold the multi-line expression into a single line.
        if: |
          steps.meta.outputs.dependency-type == 'direct:production' ||
          steps.meta.outputs.dependency-type == 'direct:development'
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread .github/workflows/rebuild-dist.yml Outdated
Co-authored-by: tingx2wang <17136661+tingx2wang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants