Skip to content

Fixed OpenAPI types for advisory fields #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apoorvd06 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed OpenAPI types for advisory fields #2420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions vulnerabilities/api_v3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from django.db.models import Q
from django_filters import rest_framework as filters
from drf_spectacular.utils import extend_schema
from drf_spectacular.utils import extend_schema_field
from packageurl import PackageURL
from rest_framework import serializers
from rest_framework import viewsets
Expand Down Expand Up @@ -117,6 +118,13 @@ class Meta:
fields = ["cwe_id", "name", "description"]


class RelatedSSVCTreeSerializer(serializers.Serializer):
vector = serializers.CharField()
decision = serializers.CharField()
options = serializers.JSONField()
source_url = serializers.URLField()


class AdvisoryV3Serializer(serializers.ModelSerializer):
aliases = serializers.SlugRelatedField(
many=True,
Expand All @@ -131,6 +139,7 @@ class AdvisoryV3Serializer(serializers.ModelSerializer):
todo_count = serializers.IntegerField(read_only=True)
curating_advisories = serializers.SerializerMethodField()

@extend_schema_field(RelatedSSVCTreeSerializer(many=True))
def get_related_ssvc_trees(self, obj):
seen = set()
result = []
Expand Down Expand Up @@ -376,6 +385,7 @@ class AffectedByAdvisoryV3Serializer(AdvisoryV3Serializer):
fixed_by_packages = serializers.SerializerMethodField()
advisory_uid = serializers.CharField(source="avid", read_only=True)

@extend_schema_field(serializers.ListField(child=serializers.CharField()))
def get_fixed_by_packages(self, obj):
return list(
obj.impacted_packages.values_list("fixed_by_packages__package_url", flat=True)
Expand Down