ci: GHA workflow security cleanup - #7
Merged
Merged
Conversation
Add persist-credentials: false to actions/checkout steps so the default GITHUB_TOKEN is not left in the local git config after checkout. Steps later in the job do not push to the repo.
Add top-level permissions: {} to both workflows and grant each job only
the GITHUB_TOKEN scopes it actually needs. The check job and the build
job in release only need contents: read; the publish jobs already
declare id-token: write for trusted publishing.
Bind ${{ steps.setup-python.outputs.python-path }} to an env variable
and reference it as "$PYTHON_PATH" in the shell script, so the value
is never interpolated into the script source.
Pin every external action reference to a full 40-char commit SHA, with the previous tag preserved as a trailing comment. This prevents an upstream tag move from silently changing what runs in CI.
Remove the actions/cache step (and its companion 'Ensure cache is
healthy' step) from the release build. Caches restored into the build
that produces published artifacts are a poisoning vector, and the cache
key referenced ${{ matrix.python-version }} from a non-matrix job so it
was resolving to an empty segment anyway. The check workflow still
caches the venv across PR/push runs.
ttypic
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine hygiene pass over the GitHub Actions workflows in this repo, addressing findings from a workflow security audit. Changes are split into five commits, one per finding type:
existing id-token: write is retained on the publish jobs).
matrix.python-version }} from a non-matrix job so it was resolving to an empty segment anyway. The check workflow still caches the venv across PR/push runs.
No behavioural changes intended — the workflows run the same checks against the same inputs.