Repository navigation
Conversation
Use valid release-asset digests while preserving links for assets without usable SHA256 values. Co-authored-by: GeneralTony007 <144252170+GeneralTony007@users.noreply.github.com>
Exercise the real shell generator with offline release JSON fixtures, including missing and unusable digests, mixed assets, backend filters, and empty indexes. Co-authored-by: GeneralTony007 <144252170+GeneralTony007@users.noreply.github.com>
Reference the maintainer's issue without claiming complete historical hash coverage. Co-authored-by: GeneralTony007 <144252170+GeneralTony007@users.noreply.github.com>
Use the assigned pull request number in the repository's changelog format. Co-authored-by: GeneralTony007 <144252170+GeneralTony007@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1340.
The wheel-index generator currently discards release-asset digests. This adds
#sha256=...fragments when GitHub supplies a valid SHA256 digest, so installers can check the downloaded wheel against it.This does not backfill hashes for historical assets without a usable digest, so it is a partial improvement toward #1340 rather than complete historical coverage.
Validation
On Python 3.11, Bash and jq:
python -m pytest tests/test_release_index.py -q: 17 passed, no skips. The same tests against the unchanged generator give 4 failed and 13 passed.python -m ruff check llama_cpp tests: passed.python -m ruff format --check llama_cpp tests: passed.bash -n scripts/releases-to-pep-503.sh: passed.git diff --check: passed.Rechecked all three published files against the tested local files byte-for-byte, then ran the checks again from the fetched branch. The native/model inference suite was not run; no native or inference code changes. These new script tests skip explicitly if Bash or jq is unavailable.
References: GitHub release-asset digests and the Simple Repository API.