Repository navigation
Conversation
Av1anJay
approved these changes
Nov 9, 2026
Av1anJay
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the complete diff, surrounding feedback flow, and the backend payload contract. No actionable blocking issues found. The new optional fields are omitted when blank, and diagnostics require an explicit opt-in.
Checks: GitHub Actions Verify passed for this head: flutter analyze, flutter test, the Chrome route geometry test, and the Node runtime test. Platform builds were still running at review time. Locally, Flutter tests/analyze could not run because Flutter is not installed; the Node test was blocked by this host’s older Node 22.23.1.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback currently accepts only a subject and details, which can leave reports without enough context to investigate. Add an optional section for a category, related route or stop, and contact details, plus an opt-in preview of app version, platform, language and display settings.
All additional fields remain optional. Blank fields are omitted, diagnostics start disabled on every visit, turning the switch off omits diagnostics, and failed submissions retain the form for retry. Includes English and Traditional Chinese labels, API payload validation and a guard against accessing disposed fields when leaving during submission.
Backend support is already on
busapiserver/main: YetAnotherBusDeveloper/busapiserver@9d875c1. Deploy that backend before releasing this app. Existing apps can continue sending onlytitleandcontent; the backend preserves the response format and migrates existing feedback records without losing data.Validation:
flutter test test/feedback_service_test.dart test/feedback_screen_test.dart— 11 tests pass.flutter analyzefor the feedback models, service, screen and tests — no issues.