Repository navigation
DELETE and RECALL with IN take the clauses in any order - #2174
Merged
Merged
Conversation
DELETE ALL FOR x IN t, DELETE NEXT 2 FOR x IN t, RECALL REST WHILE x IN t and similar didn't compile: the rules with IN only matched when the clauses came in the order of the rule. New rules move the IN clause to the front and the existing ones take the rest. Ten tests added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These didn't compile:
VFP takes the clauses in any order. Our rules for DELETE and RECALL with IN only matched when the clauses came in the order of the rule. The preprocessor accepts the optional clauses in any order only when nothing mandatory follows them, and IN does.
I added rules that move the IN clause to the front, and from there the existing rules take the rest. Nothing else changes, I compared the preprocessor output of all the test sources before and after.
LOCATE ... IN is not touched, VFP doesn't accept it. REPLACE with NEXT or REST before FOR and IN still fails, that one needs its own fix.
Ten tests added, with the values measured in VFP 9.